description: validates manifest when unpack #37
Conversation
cmd/oci-unpack/oci-unpack.1.md
Outdated
|
|
||
| # DESCRIPTION | ||
| `oci-unpack` validates an application/vnd.oci.image.manifest.v1+json and unpacks its layered filesystem to `dest`. | ||
| `oci-unpack` validates an [Image Manifest](https://github.com/opencontainers/image-spec/blob/master/manifest.md#image-manifest) and unpacks its layered filesystem to `dest`. |
There was a problem hiding this comment.
We still don't have a Makefile rule to build man pages from this Markdown source, but go-md2man (used by runtime-tools) handles links poorly. I suggest we avoid them until we have more clarity on how the man pages will be generated.
I'm fine with the original wording, because to me “validated an application/vnd.oci.image.manifest.v1+json” means the whole Merkle tree, not just a ref media type claim on the root object. However, I'd be fine with an additional sentence that made the full-tree validation explicit. Something like:
The entire Merkle tree rooted on the manifest blob is validated.
|
@wking
If it is OK? |
|
“with” → “and the”, but otherwise e0a2f66 looks good to me. |
Signed-off-by: xiekeyang <[email protected]>
|
.@wking I change |
|
f256b57 looks good to me. Maybe the “…, and …, and” would feel better to you if we use parens?
|
|
LGTM |
|
Please rebase. |
|
@xiekeyang Please rebase. |
4 participants
Actually, the validation object before unpack is whole manifest schema, not only its own media type.
Signed-off-by: xiekeyang [email protected]